Skip to content

feat: deprecate relative_path in favor of subdomain #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 4, 2022
Merged

feat: deprecate relative_path in favor of subdomain #61

merged 2 commits into from
Oct 4, 2022

Conversation

deansheather
Copy link
Member

title

@deansheather deansheather requested a review from kylecarbs October 4, 2022 17:42
kylecarbs
kylecarbs approved these changes Oct 4, 2022
View reviewed changes
Copy link
Member

@kylecarbs kylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure you run make gen!

@kylecarbs kylecarbs merged commit dfd2dd0 into main Oct 4, 2022
@kylecarbs kylecarbs deleted the dean/subdomain branch October 4, 2022 17:49
DanielleMaywood pushed a commit that referenced this pull request Sep 5, 2024
@deansheather @DanielleMaywood
feat: deprecate relative_path in favor of subdomain (#61)
011839e 
* feat: deprecate relative_path in favor of subdomain

* fixup! feat: deprecate relative_path in favor of subdomain
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylecarbs kylecarbs kylecarbs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deansheather @kylecarbs